Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CapsuleVsCapsuleAlgorithm.cpp #392

Merged

Conversation

robertocapuano
Copy link
Contributor

Hi,

I restored previous change on CapsuleVsCapsuleAlgorithm, in the last weeks I get a lot of assert failure on
assert((isTrigger && narrowPhaseInfoBatch.narrowPhaseInfos[i].nbContactPoints == 0) ||
(!isTrigger && narrowPhaseInfoBatch.narrowPhaseInfos[i].nbContactPoints > 0));

CollisionDetectionSystem::processPotentialContacts() line 1243

With this change I don't have this error.

restored previous change
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.95%. Comparing base (5807924) to head (b508b87).
Report is 5 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #392   +/-   ##
========================================
  Coverage    55.95%   55.95%           
========================================
  Files          182      182           
  Lines        13129    13127    -2     
  Branches      1172     1171    -1     
========================================
- Hits          7346     7345    -1     
+ Misses        5783     5782    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanielChappuis DanielChappuis added this to the v0.10.2 milestone Sep 3, 2024
@DanielChappuis DanielChappuis self-assigned this Sep 3, 2024
@DanielChappuis DanielChappuis changed the base branch from master to develop September 17, 2024 05:18
@DanielChappuis DanielChappuis merged commit f0cfae4 into DanielChappuis:develop Sep 17, 2024
14 checks passed
@DanielChappuis
Copy link
Owner

Thanks a lot for your pull request. I have merged it into the develop branch. This will be available in the next release of the library.

@DanielChappuis
Copy link
Owner

This is now part of the last released version of the library. Thanks for your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants