Added minimum swap to sort #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vanshikagarg17
requested review from
Ananyaas,
sakshigoel19,
Sargam-Agarwal and
SmritiOjha23
Sargam-Agarwal
requested changes
Oct 20, 2021
There was a problem hiding this comment.
Hey @vinayassrao,
everything looks good to me except for one thing. In the main function, you should not hard code the values of the array. Kindly take the input from the user.
|
@Sargam-Agarwal requested changes has been made,please review it |
Sargam-Agarwal
requested changes
Oct 20, 2021
There was a problem hiding this comment.
Hey @vinayassrao
Just do proper indentation in the swap and main function. Rest is all good now 👍
|
@Sargam-Agarwal requested changes has been made,please review it |
Sargam-Agarwal
approved these changes
Oct 20, 2021
sakshigoel19
approved these changes
Oct 20, 2021
SmritiOjha23
approved these changes
Oct 20, 2021
Vanshikagarg17
approved these changes
Oct 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check the following PR request for the issue #32