[ITDS-71] feature: Skeleton 개선 및 적용 #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wongbingg
approved these changes
Feb 16, 2025
There was a problem hiding this comment.
상진님 변경사항 모두 확인했습니다
작업량이 꽤 많았을텐데 고생하셨습니다
추가 작업 없으면 바로 머지해도 될 거같습니다 👍 @Hansangjin98
Comment on lines
+53
to
+60
| if isLoading { | ||
| let cell: PostSkeletonCell = collectionView.dequeueReusableCell(forIndexPath: indexPath) | ||
| return cell | ||
| } else { | ||
| let cell: PostCell = collectionView.dequeueReusableCell(forIndexPath: indexPath) | ||
| cell.setData(item) | ||
| return cell | ||
| } |
There was a problem hiding this comment.
스켈레톤 표출 조건 분기처리가 모든 곳에 들어가서 작업량이 많았을 텐데 고생하셨습니다 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈 번호
📘 작업 유형
📙 작업 내역 (구현 내용 및 작업 내역을 기재합니다.)
📋 체크리스트 (PR을 올리기 전에 스스로 확인해봐요!)
📝 적용 예시