fix: allow uppercase table names using haveInDatabase with postgreSql #82
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szhajdu
reviewed
Jan 31, 2025
| @@ -164,7 +164,7 @@ public function getPrimaryKey(string $tableName): array | |||
| FROM pg_index i | |||
| JOIN pg_attribute a ON a.attrelid = i.indrelid | |||
| AND a.attnum = ANY(i.indkey) | |||
| WHERE i.indrelid = '{$tableName}'::regclass | |||
| WHERE i.indrelid = " . $this->postgreQuotedName($tableName) . "::regclass | |||
There was a problem hiding this comment.
We could explicitly quote every table name without the extra overhead of a regex. I believe it's fully backward-compatible. What do you think?
Suggested change
| WHERE i.indrelid = " . $this->postgreQuotedName($tableName) . "::regclass | |
| WHERE i.indrelid = '\"{$tableName}\"'::regclass |
There was a problem hiding this comment.
I created the postgreQuotedName method because I was not sure it would be backwards compatible, but if it works, your suggestion it's ok for me.
There was a problem hiding this comment.
All tests pass. Changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix error when using
haveInDatabase()on databases with illegal table names (like uppercase chars).According to PostgreSQL Wiki:
Exception throwed:
fixes #14