Abstract syntax trees #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue did you fix?
I fixed the issue that we could not recognise complex nested functions, functions that are declared in a not normal way and increased performance.
Fixes: #41
Fixes: #22
Fixes: #10
Quick description of your approach:
Instead of finding function names and full functions with regex functions I used abstract syntax trees for this task. Unfortunately the library for parsing javascript in python is outdated that is why I have had to create a Javascript subprocess where we are using the Babel.
I also had to update the tests, because they did not use valid Javascript and could not be parsed by the abstract syntax trees.
And I increased performance by a big amount, by avoiding to parse commits multiple times.
How to run the code?
Clone the testRepo to use the updated tests. Run
npm installto install the necessary dependencies and runpython getFunctionData.pyorpython test_getFunctionData.py.Checklist before requesting a review: