-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add different sizes for dust and sea salt #564
Conversation
This works fine in amip: https://buildkite.com/clima/climacoupler-coarse-nightly-amip/builds/237. It doesn't change the result right now. I need to update ClimaAtmos to see if this new capability improves the simulation. I would like to make a patch release after this is merged. |
Actually this is going to be a breaking change as we add more aerosols in RRTMGP, and we need to initialize them correctly in ClimaAtmos. I'll make a patch release with the current main. |
Does this not work for our purpose to use (compute) one statistically representative particle size for each particle type, statistically computed based on available particle size distribution for that particle type, and use that instead? |
We talked about it offline. This gives us the most accurate optics with information about different size bins, but is slow. I can think about if we can come up with effective radius for dust and sea salt when we have an aerosol model. |
I started a benchmarking build here: https://buildkite.com/clima/rrtmgp-clima-a100-pipeline/builds/45 |
I don't think the benchmark is accurate as it reads the aerosol state from the rrtmgp example. So no matter how many aerosol categories are added, only 2 type (1 and 3) are used. |
I am ok with this if this is a
Yes. This only checks if there are no performance regressions from this PR! |
As discussed, this use case deviates from the design intent, which expects one representative particle size for each particle type. As discussed, we are ok with this as a temporary fix, if immediately needed. Eventually, we should either try to get one statistically representative particle size for each particle type, roll this back, or we can redesign this so that users can choose number of particle types they would like to use and number of bins for each particle type! |
Sounds good, thanks @sriharshakandala. |
cde4213
to
670eddb
Compare
Purpose
co-authored-by: @charleskawczynski
To-do
Content