Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error: item <...> cannot fit into pocket while loading: item is too short #78441

Open
moxian opened this issue Dec 9, 2024 · 2 comments · May be fixed by #79204
Open

error: item <...> cannot fit into pocket while loading: item is too short #78441

moxian opened this issue Dec 9, 2024 · 2 comments · May be fixed by #79204
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@moxian
Copy link
Contributor

moxian commented Dec 9, 2024

Describe the bug

On loading of an attached save:

 DEBUG    : error: item bolt_wood cannot fit into pocket while loading: item is too short

 FUNCTION : combine
 FILE     : D:\a\Cataclysm-DDA\Cataclysm-DDA\src\item_contents.cpp
 LINE     : 742
 VERSION  : 0207dfe

Attach save file

debug-world-trimmed.tar.gz

Steps to reproduce

Load the save. Observe the error.

Expected behavior

No error.

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19045.5131 (22H2)
  • Game Version: 0207dfe [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth]
    ]

Additional context

Bisected the problem to #78285
Latest good release - cdda-experimental-2024-12-07-1629
Earliest bad release - cdda-experimental-2024-12-08-0253

Now, this is probably expected. Pocket contents are (presumably, I have not looked at the code) serialized in pocket order, so things that used to be in the "main" pocket of leather backpacks (which used to be the first pocket) are now treated as being in the "tucked against the back" pocket (which is first now).

Probably the worst thing that would happen is some item spilling to the ground. Probably no items would be actually deleted. Probably. But i have not tested this so I don't know. (I don't even know where the leather backpack in the save file is because it's not on my character)

I thought I should make the bug report just in case (for github search purposes?), and if there's nothing to be done about it, then it can be closed.

@moxian moxian added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Dec 9, 2024
@Procyonae
Copy link
Contributor

Swapping the pocket order so the new pocket is last so 0.I stable doesn't have this issue would probably be better than nothing

@oosyrag oosyrag linked a pull request Jan 17, 2025 that will close this issue
@oosyrag
Copy link
Contributor

oosyrag commented Jan 17, 2025

Wooops. Sorry didn't realize order mattered. Also missed the notification for this issue ><

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants