Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the agent work with Home Assistant OS #736

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dnlldl
Copy link
Contributor

@dnlldl dnlldl commented Jul 26, 2024

General information

The current Linux agent doesn't work with Home Assistant OS (HAOS: https://www.home-assistant.io/installation/linux) because /bin/bash is in fact a redirection to /bin/sh. The openwrt agent is compatible with HAOS but doesn't provide as much information. It is notably missing the systemd agent information.

Proposed changes

To make the Linux agent work with sh, the <<< operators need to be replaced and the bash for loop syntax needs to be adapted as it is not compatible.

I am not sure what is the best approach to this as I don't have a variety of systems to test it on; it might break the agent on other systems although I didn't encounter any issue in my lab with my other Linux distros. A separate agent might be ideal but I admit we're entering a very niche OS that would not be worth supporting a completely total different agent. In that regard, it would probably be better for me to submit a new agent specifically for HAOS to the Checkmk Exchange, but I still wanted to leave a trace on the git and have your thoughts on the matter.

I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA.

@dnlldl
Copy link
Contributor Author

dnlldl commented Sep 8, 2024

there might be a problem with the read statements, this needs to be improved
the bash agent is almost already sh compatible/compliant, I don't see any disadvantage to make it fully compatible, it can only benefit some older or more restricted systems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants