Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented an in-place and out-of-place version of one of the simple sorting algorithms.
There's the following bugs/problems that I can spot right out-of-the-box
mysort
doesn't passreverse
tomysort!
AbstractArray{T}
could fail due to the non-existence of(-)(::T)
(e.g. arrays of strings)mysort
is type-stable, the return type can be weird. For examplemysort(::String) -> Vector{Char}
mysort!
will fail for arrays with weird indices (e.g. OffsetArrays)Steps for completing this assignment are as follows:
Before merging we should at least take this for a test drive. I'm looking for volunteer mentors/mentees.
If it's approved after the test-drive (or after some iteration) the README should be updated with instructions.