Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing azure #147

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

mattmgoldberg
Copy link
Collaborator

No description provided.

Contributing.md file in the phdi-azure repo is generic Github/CDCgov boilerplate. Editing reflect our actual contribution practices.
@mattmgoldberg mattmgoldberg added the documentation Improvements or additions to documentation label May 22, 2023
@mattmgoldberg mattmgoldberg self-assigned this May 22, 2023
Copy link
Collaborator

@emmastephenson emmastephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Matt! There are just a couple sections that can probably be removed.

##### Overview
This document will assume that you're using VSCode as your IDE, but other options (e.g., IntelliJ, Eclipse, PyCharm) can be used as well.

##### Installation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a couple of the following sections can be safely removed - they don't apply to phdi-azure, just phdi. It's probably safe to remove:

  • Installation
  • Testing
  • All the code coverage sections
  • Building the docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants