Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add golden patient data #4

Conversation

robertandremitchell
Copy link
Collaborator

@robertandremitchell robertandremitchell commented Oct 11, 2024

PULL REQUEST

Summary

  • Adds Hyper Unlucky as the fill field patient for most* demo cases
  • Adds Public HAPI: Direct connections
  • Makes Public HAPI: Direct connection the default FHIR Server
  • Standardizes URL formation (Patient originally did not start with /, which led to some funkiness when building FHIR URLs)
  • Made some improvements to the e2e flow (pulling the test URL into an env var, adding video playback to CI) to fix some test timeout issues
    • We suspect that Public HAPI might be a bit slow, so we may want to set up our own FHIR server to have more control over our testing / demo environment.

Related Issue

Fixes #2646

Acceptance Criteria

Please copy the acceptance criteria from your ticket and paste it here for your reviewer(s)

Additional Information

  • How do we want to handle the standard Newborn? For example, if we were to switch to Hyper Unlucky for everything, as is done for the other cases, what happens is that all the newborn screening data is returned. Do we need to create at least 1 other distinct patient to show a pass/referall/fail? Or update Hyper Unlucky to only have one newborn screening, then just have Mango/Watermelon/Cucumber in our back pocket in case we need to show a pass/referral/fail?
  • How do we want to handle the socialHistoryQuery in CustomQuery.ts? In our other patient data, we did not have social history data, so to mimic existing demo displays, I commented it out so that the social determinants of health were not present. Is it better to display them?

Unrelated, but having some trouble with the e2e tests. If I run them individually, they pass. If I replicate them, they pass. But running the full script, 4 fail. Running on GitHub Actions, 6 fail. very confusing.

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

@fzhao99 fzhao99 closed this Oct 15, 2024
@fzhao99 fzhao99 deleted the rob/2646-align-patient-info-population-between-design-and-dev branch October 15, 2024 13:44
@fzhao99 fzhao99 restored the rob/2646-align-patient-info-population-between-design-and-dev branch October 15, 2024 13:44
@fzhao99 fzhao99 reopened this Oct 15, 2024
@robertandremitchell robertandremitchell merged commit 9f49050 into main Oct 15, 2024
4 of 7 checks passed
@fzhao99 fzhao99 deleted the rob/2646-align-patient-info-population-between-design-and-dev branch October 15, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants