-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add golden patient data #4
Merged
robertandremitchell
merged 40 commits into
main
from
rob/2646-align-patient-info-population-between-design-and-dev
Oct 15, 2024
Merged
Add golden patient data #4
robertandremitchell
merged 40 commits into
main
from
rob/2646-align-patient-info-population-between-design-and-dev
Oct 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en-design-and-dev
…en-design-and-dev
…en-design-and-dev
…ent-info-population-between-design-and-dev' into rob/2646-align-patient-info-population-between-design-and-dev
…en-design-and-dev
…en-design-and-dev
robertandremitchell
requested review from
m-goggins,
DanPaseltiner and
fzhao99
October 11, 2024 14:48
…en-design-and-dev
…en-design-and-dev
…en-design-and-dev
…y-connector into bob/debug-e2es
…en-design-and-dev
…y-connector into bob/debug-e2es
…y-connector into bob/debug-e2es
fzhao99
approved these changes
Oct 15, 2024
…en-design-and-dev
fzhao99
deleted the
rob/2646-align-patient-info-population-between-design-and-dev
branch
October 15, 2024 13:44
fzhao99
restored the
rob/2646-align-patient-info-population-between-design-and-dev
branch
October 15, 2024 13:44
fzhao99
deleted the
rob/2646-align-patient-info-population-between-design-and-dev
branch
October 15, 2024 14:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
/
, which led to some funkiness when building FHIR URLs)Related Issue
Fixes #2646
Acceptance Criteria
Please copy the acceptance criteria from your ticket and paste it here for your reviewer(s)
Additional Information
socialHistoryQuery
inCustomQuery.ts
? In our other patient data, we did not have social history data, so to mimic existing demo displays, I commented it out so that the social determinants of health were not present. Is it better to display them?Unrelated, but having some trouble with the e2e tests. If I run them individually, they pass. If I replicate them, they pass. But running the full script, 4 fail. Running on GitHub Actions, 6 fail. very confusing.
Checklist