-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev dump #158
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I believe we need to mount the same volume to the db docker-compose-e2e so that the data is available for end to end tests.
Actually that reminds me that we need to also call the valueset insertion functions for the DIBBs hardcoded values / JSON dump file that you wrote at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to me. I wonder if we actually want to commit the vs_dump.sql
to github or just have it locally? or do we need to upload it for tests to pass successfully?
@robertandremitchell I believe we'll need to upload it for tests to pass once we take the migrations out. I'll have to modify the github workflow to take advantage of it. I think it's also probably good to commit it in case anyone else needs to pull things down and be able to iterate quickly, e.g. a designer who wants to test out a new feature's appearance. |
Mount a pg_dump extract to docker dev
Summary
This PR creates a
.sql
dump of the PG database just after the eRSD has successfully been loaded via a localdocker compose
run. It has been mounted into the docker dev volume to automatically run as an entrypoint script when running in dev mode.Related Issue
Fixes #122
Additional Information
Added a readme with the command needed to create the dump file in case we ever want to update the dev dump. Code tested by nuking all images,
docker system prune
ing, then just runningnpm run dev
and verifying values were in the DB via DBeaver.