query building part one #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzhao99
force-pushed
the
bob/que-32-build-in-condition-template-selection-page-pt-1
branch
from
31c32dd
to
32f5a4e
Compare
…t-1' of https://github.com/CDCgov/dibbs-query-connector into bob/que-32-build-in-condition-template-selection-page-pt-1
fzhao99
requested review from
katyasoup,
robertandremitchell,
bamader,
m-goggins,
nickclyde and
DanPaseltiner
robertandremitchell
approved these changes
Nov 7, 2024
fzhao99
deleted the
bob/que-32-build-in-condition-template-selection-page-pt-1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
Part one of query building that adds in some refactoring / componentization that's reviewable independent of the feature work. Breaking apart to make the PR easier to review.
Added a simple unit test based off the log output for what comes back from the APHL call since I was getting nervous that there wasn't any test covering the filtering / translation logic.
Should be a no op, but happy to change anything folks find in the way the components are structured
Related Issue
Part one of #75
Checklist