Skip to content

Commit

Permalink
michelle feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
fzhao99 committed Nov 8, 2024
1 parent 7f3f4db commit 8d2ecde
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 18 deletions.
4 changes: 2 additions & 2 deletions query-connector/src/app/query/components/CustomizeQuery.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -200,10 +200,10 @@ const CustomizeQuery: React.FC<CustomizeQueryProps> = ({
</div>
<LoadingView loading={!useCaseQueryResponse} />
<h1 className="page-title margin-bottom-05-important">Customize query</h1>
<h2 className="page-explainer margin-x-0-important">
<h2 className="page-explainer margin-y-0-important">
Query: {demoQueryValToLabelMap[queryType]}
</h2>
<h3 className="margin-x-0-important font-sans-sm text-light padding-bottom-0 padding-top-05">
<h3 className="margin-y-0-important font-sans-sm text-light padding-bottom-0 padding-top-05">
{countLabs} labs found, {countMedications} medications found,{" "}
{countConditions} conditions found.
</h3>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const Backlink: React.FC<BacklinkProps> = ({ onClick, label }) => {
<a
href="#"
onClick={onClick}
className="back-link unchanged-color-on-visit"
className="back-link unchanged-color-on-visit text-no-underline"
aria-label="Back arrow indicating ability to navigate back a page if clicked"
>
<Icon.ArrowBack aria-label="Arrow point left indicating return to previous step" />{" "}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const ConditionOption: React.FC<ConditionOptionProps> = ({
handleConditionSelection,
}) => {
return (
<div className="margin-y-2">
<div className="margin-y-4">
<Checkbox
onClick={() => {
handleConditionSelection(conditionId);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,6 @@
padding: 0.75rem;
}

.querySelectionFormHeader {
width: 50rem;
}

#conditionTemplateSearch:first-child {
flex: 1;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,11 @@ export default function QueryTemplateSelection() {
onClick={() => {
router.push("/queryBuilding");
}}
label={"Back to My Queries"}
label={"Back to My queries"}
/>
<h1 className={styles.queryTitle}>Custom query</h1>
<Label htmlFor="queryNameInput" className="margin-top-0-important">
Query Name
Query name
</Label>
<TextInput
id="queryNameInput"
Expand All @@ -83,13 +83,8 @@ export default function QueryTemplateSelection() {
styles.queryTemplateContainer,
)}
>
<div
className={classNames(
styles.querySelectionFormHeader,
"display-flex flex-justify flex-align-center margin-bottom-3 ",
)}
>
<h2 className="">Select condition(s)</h2>
<div className="display-flex flex-justify flex-align-center margin-bottom-3 width-full">
<h2 className="margin-y-0-important">Select condition(s)</h2>
<Button
className="margin-0"
type={"button"}
Expand Down
2 changes: 1 addition & 1 deletion query-connector/src/styles/custom-styles.scss
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ h1 {
margin-bottom: 0 !important;
}

.margin-x-0-important {
.margin-y-0-important {
margin-top: 0 !important;
margin-bottom: 0 !important;
}
Expand Down

0 comments on commit 8d2ecde

Please sign in to comment.