Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A script for setting the pool #177

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

natemcintosh
Copy link
Collaborator

The purpose of this script is to have a tool for setting up our Pool from the VAP CLI or GHA. This should help reduce a little of the complexity of the current action for setting up a pool.

Copilot generated summary below (will have copilot update again once PR is complete)

This pull request introduces a new script to create a pool in Azure Batch using Python. The script includes necessary imports, environment variable handling, and a main function to authenticate and create the pool.

Key changes:

  • Added a new Python script create_pool.py to .github/scripts directory, which includes:
    • Required Python version and dependencies for the script.
    • Import statements for necessary Azure modules and libraries.
    • Environment variable handling for BATCH_ACCOUNT and constructing the batch_url.
    • Authentication workaround using Azure's DefaultAzureCredential and BasicTokenAuthentication due to the lack of support for Azure auth flow v2 in Batch service.
    • Creation of a BatchServiceClient and adding a pool with specified parameters such as VM size and image reference.

Copy link

github-actions bot commented Jan 29, 2025

Thank you for your contribution @natemcintosh 🚀! Your pkgdown-site is ready for download 👉 here 👈!
(The artifact expires on 2025-02-06T17:35:23Z. You can re-generate it by re-running the workflow here.)

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files

📢 Thoughts on this report? Let us know!

@zsusswein zsusswein linked an issue Jan 30, 2025 that may be closed by this pull request
Doesn't fully work in current state. Waiting on assistance fixing subnet and public vs. private IP address issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize Batch pool creation script
1 participant