Rti perform #288
Draft
Rti perform #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RTI performance
mpeels
reviewed
Jan 24, 2025
| @@ -98,7 +105,7 @@ private LocalUidGeneratorDto fetchLocalId(LocalIdClass localIdClass) throws RtiC | |||
| newLocalId.setUidPrefixCd(localId.getUidPrefixCd()); | |||
| newLocalId.setTypeCd(localId.getTypeCd()); | |||
| newLocalId.setClassNameCd(localId.getClassNameCd()); | |||
| newLocalId.setSeedValueNbr(seed + LocalUidCacheModel.SEED_COUNTER + 1); | |||
| newLocalId.setSeedValueNbr(seed + LocalUidCacheModel.SEED_COUNTER + 2); | |||
There was a problem hiding this comment.
There was some discussion during the demo meeting about switching from the 1000 ID cache to a 1 at a time retrieval.
I do not have all the information on what is planned but thought sharing how Ids are fetched for patient creation might be useful.
Id generator for Modernization-api
The referenced code will:
- query to get the current seed value for the specified entity type
- increment the local_UID_generator seed value by 1
There was a problem hiding this comment.
Yeah, Anil told me about that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
Please include a summary of the change and which issue is fixed or which feature is added.
JIRA
Checklist
Types of changes
What types of changes does this PR introduces?
Testing
gradle buildpass in your local?gradle buildlogs attached?