Adding exported aksolve source code #15

mostroski · 2022-04-14T21:15:25Z

No description provided.

Ethan-DeBandi99

The functionality looks good to me. Mostly need to move testing into test directory and configure it to use pytest. A few functions could probably be split up into sub-functions for readability, but this is less important than test configuration.

Ethan-DeBandi99 · 2022-04-15T11:40:49Z

aksolve/client/aksolve/conjugate_gradients.py

+if __name__ == '__main__':
+    from aksolve.util import matvec_from_coo
+
+    print('####################')
+    print('# PERFORMING TESTS #')
+    print('####################')
+
+    host = input("enter arkouda hostname: ")
+    ak.connect(host)
+
+    print('==== Testing Conjugate Gradients ====')
+    # A = [[4, 1],
+    #      [1, 3]]
+    R = ak.array([0, 0, 1, 1])
+    C = ak.array([0, 1, 0, 1])
+    V = ak.array([4, 1, 1, 3])
+
+    x = ak.array([1/11, 7/11])  # true answer
+    b = ak.array([1, 2])        # RHS
+
+    matvec = matvec_from_coo(R, C, V)
+
+    print('\n--> RHS == 0\n')
+    ans = cg(matvec, ak.zeros(2), verbose=True)
+    assert ans[1] == 0
+
+    print('\n--> Ax == b\n')
+    ans = cg(matvec, b, x)
+    assert ans[1] == 1 and ak.all(ans[0] == x)
+
+    print('\n--> Typical Solving\n')
+    ans = cg(
+        matvec,
+        b,
+        x_start=ak.array([2, 1]),
+        max_iter=5,
+        verbose=True)
+    assert ak.all(ak.abs(ans[0] - x) < 1.0e-4)
+    assert ans[3] < 1.0e-6
+    assert ans[2] == 2
+    assert ans[1] == 3
+
+    print('\n--> Solve to Machine Precision\n')
+    ans = cg(
+        matvec,
+        b,
+        x_start=ak.array([2, 1]),
+        tol=EPS,
+        max_iter=5,
+        verbose=True)
+    assert ak.all(ak.abs(ans[0] - x) < 1.0e-4)
+    assert ans[3] < EPS
+    assert ans[2] == 3
+    assert ans[1] == 2
+
+    print('\n--> Solve with Diagonal Preconditioning\n')
+    P = lambda x: ak.array([1/4, 1/3]) * x
+    ans = cg(matvec, b, precon=P, verbose=True)
+    assert ak.all(ak.abs(ans[0] - x) < 1.0e-4)
+    assert ans[3] < EPS
+    assert ans[2] == 2
+    assert ans[1] == 2
+
+    print('\n--> Solve: Large Diagonal matrix with Diagonal Preconditioning\n')
+    D = ak.randint(1, 1000, 2 ** 32, dtype='float64')
+    matvec = lambda x: x * D
+    x = ak.randint(0, 1, 2 ** 32, dtype='float64')
+    P = lambda x: x * (1.0 / D)
+    b = matvec(x)
+    ans = cg(matvec, b, precon=P, verbose=True)
+    assert ak.all(ak.abs(ans[0] - x) < 1.0e-4)
+    assert ans[3] < 1.0e-6
+    assert ans[2] == 1
+    assert ans[1] == 3
+
+    print('##############')
+    print('# YOU PASSED #')
+    print('##############')


This needs to be moved into a test directory (same level as client). Configure to use pytest.

Ethan-DeBandi99 · 2022-04-15T11:45:54Z

aksolve/client/aksolve/minres.py

+from aksolve.util import eye, EPS, FMAX, inner, norm, Operator
+
+
+def minres(


Adding the comment here so It is easier overall. I am thinking we may want to break some of these calculations into sub-functions for readability. The functionality looks good to me, but it looks like there are sections that would easily break out.

Added Issue #35 to track

Ethan-DeBandi99 · 2022-04-15T11:46:42Z

aksolve/client/aksolve/minres.py

+if __name__ == '__main__':
+    from aksolve.util import matvec_from_coo
+
+    print('####################')
+    print('# PERFORMING TESTS #')
+    print('####################')
+
+    host = input("enter arkouda hostname: ")
+    ak.connect(host)
+
+    print('==== Testing MINRES ====')
+    # A = [[ 6.,  3.,  0.],
+    #      [ 3., -2.,  5.],
+    #      [ 0.,  5.,  2.]]
+    R = ak.array([0, 0, 0, 1,  1, 1, 2, 2, 2])
+    C = ak.array([0, 1, 2, 0,  1, 2, 2, 1, 2])
+    V = ak.array([6, 3, 0, 3, -2, 5, 0, 5, 2])
+
+    x = ak.array([2., -2., 9.])
+    b = ak.array([6., 55., 8.])
+
+    matvec = matvec_from_coo(R, C, V)
+    assert ak.all(matvec(x) == b)
+
+    print('\n--> RHS == 0\n')
+    ans = minres(matvec, ak.zeros(3), verbose=True)
+    assert ans[1] == 0
+
+    print('\n--> Ax == b\n')
+    ans = minres(matvec, b, x, verbose=True)
+    assert ans[1] == 0 and ak.all(ans[0] == x)
+
+    print('\n--> Typical Solving\n')
+    ans = minres(matvec, b, max_iter=3, verbose=True)
+    print(ans)
+    assert ak.all(ak.abs(ans[0] - x) < 1.0e-4)
+    assert ans[3] < 1.0e-6
+    assert ans[2] == 3
+    assert ans[1] == 1
+
+    print('\n--> Solve with Preconditioning\n')
+    invV = ak.array([0.15104167, 0.03125, -0.078125, 0.03125, -0.0625,
+                     0.15625, -0.078125, 0.15625, 0.109375])
+    precon = matvec_from_coo(R, C, invV)
+    ans = minres(matvec, b, precon=precon, verbose=True)
+    print(ans)
+    assert ak.all(ak.abs(ans[0] - x) < 1.0e-4)
+    assert ans[3] <= 1.0e-6
+    assert ans[2] == 2
+    assert ans[1] == 2
+
+    print('\n--> Solve: Large Diagonal matrix with Diagonal Preconditioning\n')
+    D = ak.randint(1, 1000, 2 ** 32, dtype='float64')
+    matvec = lambda x: x * D
+    x = ak.randint(0, 1, 2 ** 32, dtype='float64')
+    P = lambda x: x * (1.0 / D)
+    b = matvec(x)
+    ans = minres(matvec, b, precon=P, verbose=True)
+    assert ak.all(ak.abs(ans[0] - x) < 1.0e-4)
+    assert ans[3] < 1.0e-6
+    assert ans[2] == 1
+    assert ans[1] == 3
+
+    print('##############')
+    print('# YOU PASSED #')
+    print('##############')


Again, we need to move this to a tests directory and configure to use pytest.

Ethan-DeBandi99 · 2022-04-15T11:53:00Z

aksolve/client/aksolve/symmlq.py

@@ -0,0 +1,242 @@
+def symmlq(


This function looks to have less natural breakpoints than the other, but I definitely think we could sub-function some elements out for readability here.

mhmerrill · 2022-05-06T14:48:11Z

aksolve/client/aksolve/__init__.py

@@ -0,0 +1,2 @@
+from aksolve.util import *


did you mean to import symmlq.py and minres.py stuff?

mhmerrill · 2022-05-06T14:49:15Z

aksolve/test/aksolve_test.py

+        self.assertEqual(ans[1], 3)
+
+
+#TODO: finish converting these


do these things still need to be worked?

Added issue #34 to track

mhmerrill

i left comments

mhmerrill

looks ok to start, we will put in issues to cover changes that need to be made to work with the current version of Arkouda.

Adding exported aksolve source code

195bee4

mostroski requested review from Ethan-DeBandi99, stress-tess and mhmerrill April 14, 2022 21:15

Ethan-DeBandi99 previously requested changes Apr 15, 2022

View reviewed changes

removing old test code and creating new test directory/file

a2c2371

mhmerrill reviewed May 6, 2022

View reviewed changes

mhmerrill self-requested a review May 6, 2022 16:03

mhmerrill approved these changes May 6, 2022

View reviewed changes

mhmerrill merged commit 3a24d34 into Bears-R-Us:main May 6, 2022

mostroski deleted the aksolve branch May 12, 2022 15:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding exported aksolve source code #15

Adding exported aksolve source code #15

mostroski commented Apr 14, 2022

Ethan-DeBandi99 left a comment

Ethan-DeBandi99 Apr 15, 2022

Ethan-DeBandi99 Apr 15, 2022

Ethan-DeBandi99 May 6, 2022

Ethan-DeBandi99 Apr 15, 2022

Ethan-DeBandi99 Apr 15, 2022

mhmerrill May 6, 2022

mhmerrill May 6, 2022

Ethan-DeBandi99 May 6, 2022

mhmerrill left a comment

mhmerrill left a comment

		from aksolve.util import eye, EPS, FMAX, inner, norm, Operator


		def minres(

Adding exported aksolve source code #15

Adding exported aksolve source code #15

Conversation

mostroski commented Apr 14, 2022

Ethan-DeBandi99 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mhmerrill left a comment

Choose a reason for hiding this comment

mhmerrill left a comment

Choose a reason for hiding this comment