perf: use vmname-nic for network interface names #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tallaxes
added
area/networking
| @@ -410,6 +410,11 @@ func (p *Provider) launchInstance( | |||
| return resp, instanceType, nil | |||
| } | |||
|
|
|||
| func getNetworkInterfaceName(vmName string) string { | |||
| // cloud-provider-azure has certain optimizations (can avoid extra API calls) if this pattern is followed | |||
There was a problem hiding this comment.
Can we link to the parts from cloud provider azure this is referencing?
Pull Request Test Coverage Report for Build 8734038138Details
💛 - Coveralls |
tallaxes
added
the
size/S
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses "vmname-nic" when naming network interfaces, as cloud-provider-azure has some optimizations for this case. Minor other cleanup.
How was this change tested?
make presubmitDoes this change impact docs?
Release Note