Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completing adding the two 'procedure' resource class parameters for 'OSConfig for MC' #857

Open
wants to merge 17 commits into
base: dev
Choose a base branch
from

Conversation

MariusNi
Copy link
Contributor

@MariusNi MariusNi commented Feb 6, 2025

Description

Changes in this PR include:

  • Further completing the work started to add support for the two new resource class optional parameters.
  • Creating a simple way to swap the current baseline library to link to the NRP, with a common interface.
  • Each new policy package will have a new sub-folder under /adapters/mc and there add implementation for their common baseline interface (from adapters/mc/Baseline.h) and in their CMakeList.txt link to their own static libraries.
  • In particular, SSH and ASB have same asb library and interface implementation in their local Baseline.c. Compliance can add new such interface implementation C or C++ files under each new directory created under adapters/mc (and avoid linking to the asb library).

Checklist

  • I have read the contribution guidelines.
  • All unit tests are passing.
  • I have merged the latest dev branch prior to this PR submission.
  • I ran pre-commit on my changes prior to this PR submission.
  • I submitted this PR against the dev branch.

@MariusNi MariusNi requested a review from a team as a code owner February 6, 2025 22:41
Copy link

github-actions bot commented Feb 6, 2025

Test Results

   16 files   -    28    122 suites  +78   16m 32s ⏱️ - 21m 19s
  173 tests +  169    173 ✅ +  169  0 💤 ± 0  0 ❌ ±0 
2 669 runs  +2 493  2 669 ✅ +2 515  0 💤  - 22  0 ❌ ±0 

Results for commit cfb1cd9. ± Comparison against base commit 4fa1614.

This pull request removes 4 and adds 173 tests. Note that renamed tests count towards both.
/mnt/vss/_work/azure-osconfig/azure-osconfig/src/tests/universal-nrp-e2e/UniversalNRP.Tests.ps1 ‑ Validate Universal NRP.Get.Ensure all resource instances have status
/mnt/vss/_work/azure-osconfig/azure-osconfig/src/tests/universal-nrp-e2e/UniversalNRP.Tests.ps1 ‑ Validate Universal NRP.Get.Ensure resons are properly populated
/mnt/vss/_work/azure-osconfig/azure-osconfig/src/tests/universal-nrp-e2e/UniversalNRP.Tests.ps1 ‑ Validate Universal NRP.Get.Ensure the total resource instances count
/mnt/vss/_work/azure-osconfig/azure-osconfig/src/tests/universal-nrp-e2e/UniversalNRP.Tests.ps1 ‑ Validate Universal NRP.Set.Perform remediation
CommandRunnerTests ‑ CancelCommand
CommandRunnerTests ‑ CancelCommandInProgress
CommandRunnerTests ‑ CommandEquality
CommandRunnerTests ‑ CommandStatus
CommandRunnerTests ‑ Deserialize
CommandRunnerTests ‑ DeserializeCommandStatus
CommandRunnerTests ‑ ExecuteCommand
CommandRunnerTests ‑ GetInvalidComponent
CommandRunnerTests ‑ GetInvalidObject
CommandRunnerTests ‑ GetInvalidPayload
…

♻️ This comment has been updated with latest results.

@MariusNi MariusNi requested a review from wupeka February 6, 2025 23:14
src/adapters/mc/OsConfigResource.c Outdated Show resolved Hide resolved
src/adapters/mc/OsConfigResource.c Outdated Show resolved Hide resolved
src/adapters/mc/OsConfigResource.c Outdated Show resolved Hide resolved
src/adapters/mc/OsConfigResource.c Show resolved Hide resolved
src/adapters/mc/OsConfigResource.c Outdated Show resolved Hide resolved
src/adapters/mc/OsConfigResource.c Show resolved Hide resolved
src/adapters/mc/OsConfigResource.c Outdated Show resolved Hide resolved
src/adapters/mc/OsConfigResource.c Outdated Show resolved Hide resolved
src/adapters/mc/OsConfigResource.c Show resolved Hide resolved
src/adapters/mc/OsConfigResource.c Outdated Show resolved Hide resolved
src/adapters/mc/OsConfigResource.c Show resolved Hide resolved
src/modules/test/recipes/SecurityBaselineTests.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants