Only install aziot config if the directory exists #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariusNi
reviewed
Nov 8, 2024
jepio
force-pushed
the
stop-config-install
branch
from
8e9a85c
to
fe5fb3e
Compare
robertschaedler3
approved these changes
Nov 8, 2024
Signed-off-by: Jeremi Piotrowski <[email protected]>
jepio
force-pushed
the
stop-config-install
branch
from
fe5fb3e
to
04540a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check if
/etc/aziotexists before trying to install it during build. This change fixes a build failure on machines when the build is running as non-root. We should never be writing files to /etc/ during building and no one should be building as root.Ideally this custom command would be removed or moved behind a cmake
option().Checklist
mainbranch prior to this PR submission.mainbranch.