Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cli-feed with the new CDN domain #606

Merged
merged 4 commits into from
Feb 21, 2025
Merged

Update cli-feed with the new CDN domain #606

merged 4 commits into from
Feb 21, 2025
+3,114 −2,701

Conversation

soninaren
Copy link
Member

@soninaren soninaren commented Feb 13, 2025 •
edited
Loading

resolves #603
Updating the CDN references in the cli-feed.

@soninaren soninaren requested a review from a team as a code owner February 13, 2025 22:50
mattchenderson
mattchenderson reviewed Feb 14, 2025
View reviewed changes
Copy link
Contributor

@mattchenderson mattchenderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You had mentioned offline that some links that were posing a challenge. Is there anything in that which would be blocking?

I can confirm that I can't find the old domain in the repo, other than what is being fixed in #605 and the Readme. Should we work the readme changes into one of these PRs as well?

@soninaren
Copy link
Member Author

soninaren commented Feb 18, 2025 •
edited
Loading

You had mentioned offline that some links that were posing a challenge. Is there anything in that which would be blocking?

I can confirm that I can't find the old domain in the repo, other than what is being fixed in #605 and the Readme. Should we work the readme changes into one of these PRs as well?

For some reason I thought #605 included the readme changes. I will update this PR to include the changes to readme.md.

I don't see anything blocking, the links that posed a challenge were related to templates. I think we should be good there.

@soninaren soninaren force-pushed the nasoni/toolingFeedCdn branch from bd363fe to 3dd35a1 Compare February 19, 2025 00:10
@soninaren soninaren merged commit 2dc74c3 into release/main Feb 21, 2025
5 checks passed
@soninaren soninaren deleted the nasoni/toolingFeedCdn branch February 21, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattchenderson mattchenderson mattchenderson left review comments

@fabiocav fabiocav fabiocav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update CDN domain for Tooling Feed
3 participants
@soninaren @fabiocav @mattchenderson