Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fail the upload script if an error occur (#74) #76

Merged
merged 2 commits into from
May 24, 2024
Merged

fix: fail the upload script if an error occur (#74) #76

merged 2 commits into from
May 24, 2024

Conversation

sinedied
Copy link
Contributor

Purpose

DO NOT MERGE until end of the week

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

@sinedied sinedied marked this pull request as ready for review May 24, 2024 07:13
@sinedied sinedied requested review from glaucia86 and diberry May 24, 2024 07:13
glaucia86
glaucia86 approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glaucia86 glaucia86 merged commit e94f5b2 into main May 24, 2024
5 checks passed
@glaucia86 glaucia86 deleted the upload-fail branch May 24, 2024 21:24
@sinedied sinedied mentioned this pull request Jul 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glaucia86 glaucia86 glaucia86 approved these changes

@diberry diberry Awaiting requested review from diberry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sinedied @glaucia86