feat: allow to run the model locally with ollama and faiss (#17) #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glaucia86
reviewed
Apr 4, 2024
| @@ -123,15 +124,18 @@ This will start the web app and the API locally. Open the URL `http://localhost: | |||
|
|
|||
| First you need to provision the Azure resources needed to run the sample. Follow the instructions in the [Deploy the sample to Azure](#deploy-the-sample-to-azure) section to deploy the sample to Azure, then you'll be able to run the sample locally using the deployed Azure resources. | |||
|
|
|||
| Once your deployment is complete, you can run the following commands to start the application locally: | |||
| Once your deployment is complete, you should see a `.env` file in the `src/api` folder. This file contains the environment variables needed to run the application using Azure resources. | |||
There was a problem hiding this comment.
That .env file in the folder... I'll have to change the .env.sample.
There are other variables to include in this project
glaucia86
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Many of the things you've done I've thought about refactoring as well. I had even made an example here to test it and in fact the new v4 model allows you to do that!
Link: https://github.com/glaucia86/aoia-langchain-azurefunctions/tree/GL/applying-solid-cleanarch
Very good. Approved!
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
If no
.envis provided, the app will now automatically fall back to using local models and DB.@glaucia86 I apologize in advance for the messy PR, I also went through the whole project to refactor a bit and simplify the code as much as possible, but it seems I missed some intermediate commits when renaming files and git lost track of the renames. Because of the changes, we'll also have to update your tutorials docs. I have one further PR coming to improve the prompts then we can go through all the docs to make sure it's up to date.
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?