Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: swa cli workaround #27

Merged
merged 2 commits into from
Apr 3, 2024
Merged

chore: swa cli workaround #27

merged 2 commits into from
Apr 3, 2024

Conversation

sinedied
Copy link
Contributor

@sinedied sinedied commented Apr 3, 2024

Purpose

SWA CLI doesn't work with Node v20 correctly at this time, and as we don't need the local auth emulator I've removed it in favor of using vite dev proxy directly.

Does this introduce a breaking change?

[ ] Yes
[x] No

Copy link
Contributor

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glaucia86 glaucia86 assigned glaucia86 and sinedied and unassigned glaucia86 Apr 3, 2024
@glaucia86 glaucia86 added the bug Something isn't working label Apr 3, 2024
@glaucia86 glaucia86 merged commit 11ce8d0 into main Apr 3, 2024
5 checks passed
@glaucia86 glaucia86 deleted the swa-cli-workaround branch April 3, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants