Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimised infrastructure deployment, fixed AppInsights telemetry #3

Closed
wants to merge 7 commits into from

Conversation

Gordonby
Copy link

@Gordonby Gordonby commented Oct 7, 2021

Purpose

I didn't find that App Insights was correctly wired up, so what started as a simple fix ended up as

  • Rewritten Arm JSON as Bicep.
  • Optimised the process for getting connectionstring for cosmos, it's all done in the bicep now - no powershell needed
  • Optimised the deployment of code to app service, it's all done in the bicep now (pulling from GitHub) - no local az or git commands
  • Optimised a bunch of little things in the Arm Json, (param metadata/defaults/etc), bumping up resource API version where I could
  • Enabled in app diagnostic logging for App Service
  • Fixed the App Service -> App Insights link so telemetry flows
  • Simplified the deployment script

Does this introduce a breaking change?

[ ] Yes
[X ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[x] Feature
[x] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

How to Test

Follow the readme instructions

@Gordonby
Copy link
Author

Gordonby commented Oct 7, 2021

@issacnitin - I see you bugfixed the deploymentscript a few hours ago. Happy to chat about the PR if you need.

@Gordonby
Copy link
Author

Closing due to lack of engagement from repo owners.

@Gordonby Gordonby closed this Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant