Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmos DB account must be lowercase #21

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Conversation

ntrogh
Copy link
Contributor

@ntrogh ntrogh commented Mar 7, 2023

Purpose

  • Update the deployment script to ensure the generated Cosmos DB account name is only using lowercase.
    Several users have gotten a 503 error when loading the sample application because the Cosmos DB could not be created as a result of incorrect naming.

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

  • Update the sample application deployment script to force the Cosmos DB account name to be lowercase.
[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • Run deploymentscript.ps1 and provide an uppercase web app name as input.
  • Verify that the Cosmos DB account is successfully created.

Other Information

@ninallam ninallam merged commit f909000 into Azure-Samples:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants