Skip to content

Commit

Permalink
Update test
Browse files Browse the repository at this point in the history
  • Loading branch information
milderhc committed Jan 22, 2025
1 parent 8c46067 commit 1d3d6ea
Showing 1 changed file with 3 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import com.azure.search.documents.SearchAsyncClient;
import com.microsoft.openai.samples.rag.ask.approaches.PlainJavaAskApproach;
import com.microsoft.openai.samples.rag.ask.approaches.semantickernel.JavaSemanticKernelChainsApproach;
import com.microsoft.openai.samples.rag.ask.approaches.semantickernel.JavaSemanticKernelWithVectorStoreApproach;
import com.microsoft.openai.samples.rag.chat.approaches.PlainJavaChatApproach;
import com.microsoft.openai.samples.rag.proxy.AzureAISearchProxy;
import org.junit.jupiter.api.Test;
Expand Down Expand Up @@ -38,10 +39,8 @@ void testCreateApproachWithJavaPlain() {

@Test
void testCreateApproachWithJavaSemanticKernelMemory() {
assertThrows(IllegalArgumentException.class, () -> {
RAGApproach approach = ragApproachFactory.createApproach("jsk", RAGType.ASK, null);
});
//assertInstanceOf(JavaSemanticKernelWithMemoryApproach.class, approach);
RAGApproach approach = ragApproachFactory.createApproach("jsk", RAGType.ASK, null);
assertInstanceOf(JavaSemanticKernelWithVectorStoreApproach.class, approach);
}

@Test
Expand Down

0 comments on commit 1d3d6ea

Please sign in to comment.