Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter the allowed location to use EastUs2, and avoid deploy issues #393

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

elbruno
Copy link
Collaborator

@elbruno elbruno commented Jan 24, 2025

Purpose

  • Filter the allowed location to use EastUs2, and avoid deploy issues

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Deploy
azd up

What to Check

Verify that the following are valid

  • Deploy works correctly

@elbruno elbruno requested a review from Copilot January 24, 2025 22:38

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • infra/main.bicep: Language not supported
Comments suppressed due to low confidence (2)

README.md:174

  • The region name 'EastUS2' is inconsistent with 'East US 2' used elsewhere. It should be renamed to 'East US 2'.
> This application uses the `gpt-4o-mini` model. When choosing which region to deploy to, make sure they're available in that region (i.e. EastUS2). For more information, see the [Azure OpenAI Service documentation](https://learn.microsoft.com/en-us/azure/ai-services/openai/concepts/models#standard-deployment-model-availability).

README.md:330

  • The region name 'eastus2' is inconsistent with 'East US 2' used elsewhere. It should be renamed to 'East US 2'.
azd env set AZURE_OPENAI_RESOURCE_LOCATION eastus2 # Please check the gpt model availability for more details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant