Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for embedding dimensions and fix prepdocs on Windows #342

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mattgotteiner
Copy link

@mattgotteiner mattgotteiner commented Aug 1, 2024

Purpose

  • Add support for embedding models with the dimensions parameter in Azure OpenAI
  • Fix prepdocs runs on Windows

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Set AZURE_OPENAI_EMBEDDING_MODEL_DIMENSIONS and another embedding model (e.g. text-embedding-3-large) that supports other types of dimensions
  • Run ./scripts/prepdocs.ps1 on Windows

What to Check

Verify that the following are valid

  • The container app does not crash when you chat with it
  • You can upload new documents without crashing
  • The index has the correct embedding dimensions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant