Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated branding to use "Azure AI Search" #323

Merged
merged 1 commit into from
May 28, 2024
Merged

Updated branding to use "Azure AI Search" #323

merged 1 commit into from
May 28, 2024

Conversation

jmatthiesen
Copy link
Collaborator

Fixes #321 - updating branding in this sample to use "Azure AI Search" instead of the older branding of "Azure Cognitive Search"

Purpose

Updating to use current branding for Azure AI Search.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code, review README and descriptions in modified files.

@jmatthiesen jmatthiesen added the documentation Improvements or additions to documentation label May 23, 2024
@jmatthiesen jmatthiesen self-assigned this May 23, 2024
diberry
diberry approved these changes May 28, 2024
View reviewed changes
Copy link

@diberry diberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

luisquintanilla
luisquintanilla approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@luisquintanilla luisquintanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jmatthiesen. LGTM. :shipit:

@jmatthiesen jmatthiesen merged commit e2dc0aa into main May 28, 2024
5 checks passed
@jmatthiesen jmatthiesen deleted the dev/jmatthiesen/updateAISearchBranding branch May 28, 2024 16:24
mohamedsaif added a commit to mohamedsaif/azure-search-openai-demo-csharp that referenced this pull request Jun 4, 2024
@mohamedsaif
Merge pull request #2 from mohamedsaif/main
03579b3 
Updated branding to use "Azure AI Search" (Azure-Samples#323)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisquintanilla luisquintanilla luisquintanilla approved these changes

@diberry diberry diberry approved these changes

@JakeRadMSFT JakeRadMSFT Awaiting requested review from JakeRadMSFT

Assignees

@jmatthiesen jmatthiesen

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Azure Cognitive Search -> Azure AI Search branding change
3 participants
@jmatthiesen @diberry @luisquintanilla