Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to .NET 8.0 GA bits - all packages #243

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Upgrade to .NET 8.0 GA bits - all packages #243

merged 1 commit into from
Nov 29, 2023

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Nov 29, 2023 •
edited
Loading

  • Remove unused Directory.Build.props
  • Upgrade to .NET 8.0 GA bits and other packages
  • Correct Azure Search usage (APIs renamed)
  • Remove unused using
  • Fix formatting

Closes #239

@IEvangelist
Copy link
Member Author

IEvangelist commented Nov 29, 2023 •
edited
Loading

This one upgrade all packages - and fixes broken APIs in the process, it supersedes #239 - Sorry @Eilon, I didn't see your PR.

@IEvangelist IEvangelist merged commit a9ebec9 into Azure-Samples:main Nov 29, 2023
2 checks passed
IEvangelist added a commit to IEvangelist/azure-search-openai-demo-csharp that referenced this pull request Dec 5, 2023
@IEvangelist
Upgrade to .NET 8.0 GA bits - all packages (Azure-Samples#243)
b99fd24 
- Remove unused `Directory.Build.props`
- Upgrade to .NET 8.0 GA bits and other packages
- Correct Azure Search usage (APIs renamed)
- Remove unused `using`
- Fix formatting

Closes Azure-Samples#239
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LittleLittleCloud LittleLittleCloud LittleLittleCloud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IEvangelist @LittleLittleCloud