Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial doc updates #188

Merged
merged 7 commits into from
Oct 17, 2023
Merged

Initial doc updates #188

merged 7 commits into from
Oct 17, 2023

Conversation

luisquintanilla
Copy link
Collaborator

@luisquintanilla luisquintanilla commented Oct 12, 2023

Purpose

Fix documentation related issues. Tracked in #174

Fixes #133
Fixes #171
Fixes #173
Fixes #176

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@luisquintanilla
Copy link
Collaborator Author

Thanks @aaronpowell for the review. I'll take a look

Co-authored-by: Aaron Powell <[email protected]>
@luisquintanilla
Copy link
Collaborator Author

@IEvangelist can I please get an approval on this. Thank you.

@luisquintanilla luisquintanilla merged commit 7e2f1c5 into main Oct 17, 2023
@luisquintanilla luisquintanilla deleted the update-documentation branch October 17, 2023 16:59
IEvangelist pushed a commit to IEvangelist/azure-search-openai-demo-csharp that referenced this pull request Dec 5, 2023
## Purpose

Fix documentation related issues. Tracked in Azure-Samples#174 

Fixes Azure-Samples#133
Fixes Azure-Samples#171
Fixes Azure-Samples#173 
Fixes Azure-Samples#176

## Does this introduce a breaking change?
<!-- Mark one with an "x". -->
```
[ ] Yes
[x] No
```

## Pull Request Type
What kind of change does this Pull Request introduce?

<!-- Please check the one that applies to this PR using "x". -->
```
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:
```

## How to Test
*  Get the code

```
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
```

* Test the code
<!-- Add steps to run the tests suite and/or manually test -->
```
```

## What to Check
Verify that the following are valid
* ...

## Other Information
<!-- Add any other helpful information that may be needed here. -->

---------

Co-authored-by: Aaron Powell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants