Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve spam detection #3145

Merged
merged 3 commits into from
Mar 27, 2023
Merged

Improve spam detection #3145

merged 3 commits into from
Mar 27, 2023

Conversation

justindg
Copy link
Contributor

@justindg justindg commented Mar 20, 2023

Note:
Need to approve this first: AlphaWallet/TokenTest#1


Summary:

  • Added SPAM enum to TokenGroup
  • Imported spam icon as a local resource
  • Used local spam icon when Spam token is detected
  • Excluded spam token value from wallet value summary
  • Greyed out spam token value
  • Automatically set isEnabled value to false when spam token is detected
  • Fixed formatting of affected files

@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for alpha-wallet-android:

User Total reviews Time to review Total comments
seabornlee
🥇
4
▀▀▀
10h 14m
▀▀▀▀
3
▀▀▀▀▀
JamesSmartCell
🥈
7
▀▀▀▀▀
18h 27m
▀▀▀▀▀▀
3
▀▀▀▀▀
justindg
🥉
2
▀▀
10m
0

@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Patch coverage: 9.18% and no project coverage change.

Comparison is base (cf609cb) 7.68% compared to head (bc0fb3b) 7.68%.

❗ Current head bc0fb3b differs from pull request most recent head ea61fb7. Consider uploading reports for the commit ea61fb7 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##             master   #3145   +/-   ##
========================================
  Coverage      7.68%   7.68%           
  Complexity      902     902           
========================================
  Files           653     653           
  Lines         44176   44208   +32     
  Branches       4455    4459    +4     
========================================
+ Hits           3394    3397    +3     
- Misses        40494   40522   +28     
- Partials        288     289    +1     
Impacted Files Coverage Δ
.../alphawallet/app/ui/widget/holder/TokenHolder.java 0.00% <0.00%> (ø)
...ain/java/com/alphawallet/app/widget/TokenIcon.java 12.95% <10.00%> (+0.45%) ⬆️
...java/com/alphawallet/app/entity/TokensMapping.java 53.84% <25.00%> (-12.83%) ⬇️
...m/alphawallet/app/entity/tokendata/TokenGroup.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@justindg
Copy link
Contributor Author

Hold for now - will bundle the file to local assets instead

Copy link
Member

@JamesSmartCell JamesSmartCell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justindg I have a PR that sits alongside this one.

@JamesSmartCell JamesSmartCell merged commit b1e7314 into master Mar 27, 2023
@JamesSmartCell JamesSmartCell deleted the improve-spam-detection branch March 27, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment