Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor fetching logs #24

Merged
merged 4 commits into from
Nov 22, 2024
Merged

refactor fetching logs #24

merged 4 commits into from
Nov 22, 2024

Conversation

rabi-siddique
Copy link
Collaborator

@rabi-siddique rabi-siddique commented Nov 22, 2024 •
edited
Loading

The PR does the following:

  • Makes sure we fetch logs using GCP's client and don't do it via REST.
  • Make sure we have functions that are reusable for fetching logs.

@rabi-siddique rabi-siddique force-pushed the rs-refactor-fetching-logs branch 2 times, most recently from c19857e to 0ce9bd2 Compare November 22, 2024 12:05
@rabi-siddique rabi-siddique force-pushed the rs-refactor-fetching-logs branch from 0ce9bd2 to 7872b6f Compare November 22, 2024 12:06
@rabi-siddique rabi-siddique merged commit d9f181d into main Nov 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rabi-siddique