test(multichain-testing): unique wallet per test #11014
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
b6b1bb9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://aa883ccc.agoric-sdk.pages.dev |
| Branch Preview URL: | https://pc-account-balances-queries.agoric-sdk.pages.dev |
0xpatrickdev
commented
Feb 18, 2025
Comment on lines
+47
to
48
| const agoricAddr = wallets[walletName]; | ||
| const wdUser1 = await provisionSmartWallet(agoricAddr, { |
There was a problem hiding this comment.
We might consider moving provisionSmartWallet to test.before() and reusing it across runs to speed up the test. For now, this is expedient.
- this test was using 3 wallets for 6 test runs. refactor to use 1 wallet per test - refs: #9934
0xpatrickdev
force-pushed
the
pc/account-balances-queries-flake
branch
from
fd4febf to
b6b1bb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #9934
Description
account-balances-queries.test.tsappears in many of the recentmultichain-testingflakes. This test file was using 3 wallets for 6 test runs. This PR refactors to use 1 wallet per test.Security Considerations
None
Scaling Considerations
None
Documentation Considerations
None
Testing Considerations
Towards the goal of quelling CI flakes
Upgrade Considerations
None