Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use server categories in cli report #89

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

ErikBjare
Copy link
Member

@ErikBjare ErikBjare commented Jan 9, 2025

Doesn't actually work due to #88


Important

Refactor CLI report to use server categories and add limit option, with query adjustments for browser events.

  • CLI Changes:
    • In cli.py, report() now uses get_classes() instead of default_classes for server categories.
    • Added --limit option to report() to specify the number of top results to display.
  • Query Changes:
    • In queries.py, fullDesktopQuery() now conditionally includes browser event queries only if browser buckets exist.
    • Refactored query construction in fullDesktopQuery() to handle cases without browser buckets.

This description was created by Ellipsis for 8c1d993. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to e094d95 in 36 seconds

More details
  • Looked at 25 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. aw_client/cli.py:161
  • Draft comment:
    Consider using get_classes() instead of default_classes for consistency with the report function. This change is intended to dynamically fetch classes, but note that it may not work due to the issue mentioned in the PR description.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.

Workflow ID: wflow_4bTdPIqWLpjrkWyy


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@ErikBjare ErikBjare force-pushed the dev/use-server-categories-in-cli-report branch from 8c1d993 to e92c305 Compare January 9, 2025 14:41
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 8c1d993 in 22 seconds

More details
  • Looked at 155 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. aw_client/cli.py:206
  • Draft comment:
    Use the variable 'n' instead of hardcoding 10 to respect the limit parameter.
for event in sorted(events, key=lambda e: e.duration, reverse=True)[:n]
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.

Workflow ID: wflow_YAOjuxIGdrN5YaJA


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on e92c305 in 21 seconds

More details
  • Looked at 155 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. aw_client/cli.py:206
  • Draft comment:
    Use the 'n' parameter instead of hardcoding 10 for slicing events to respect the user-provided limit.
for event in sorted(events, key=lambda e: e.duration, reverse=True)[:n]
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.

Workflow ID: wflow_AogfU3HihTDVzobJ


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@ErikBjare ErikBjare merged commit 81a57df into master Jan 9, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant