Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped upload-artifact action from v3 to v4 #1827

Closed
wants to merge 5 commits into from
Closed

Bumped upload-artifact action from v3 to v4 #1827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a58efc3
Bumped upload-artifact action from v3 to v4
reinecke Jan 30, 2025
62bf6ca
attempting to disambigua
reinecke Jan 30, 2025
c57e115
Each wheel artifact in the matrix has a unique name rather than using…
reinecke Jan 30, 2025
7a6b110
I accidentally a dollar sign
reinecke Jan 30, 2025
9c3cd99
Removed star from python-build matrix variable so it can be used in a…
reinecke Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/pypi-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ jobs:
workflow: python-package.yml
workflow_conclusion: success
commit: ${{ github.sha }}
name: wheels
name_is_regexp: true
name: wheel-.*
path: dist

- name: Download sdist from commit ${{ github.sha }}
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/python-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,9 +172,9 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, windows-latest, macos-13, macos-latest]
python-build: ['cp37*', 'cp38*', 'cp39*', 'cp310*', 'cp311*', 'cp312*']
python-build: ['cp37', 'cp38', 'cp39', 'cp310', 'cp311', 'cp312']
exclude:
- { os: macos-latest, python-build: 'cp37*' }
- { os: macos-latest, python-build: 'cp37' }
steps:
- uses: actions/checkout@v4

Expand All @@ -187,15 +187,15 @@ jobs:
with:
output-dir: wheelhouse
env:
CIBW_BUILD: ${{ matrix.python-build }}
CIBW_BUILD: ${{ matrix.python-build }}*
CIBW_SKIP: '*musllinux*'
CIBW_ARCHS_LINUX: x86_64 aarch64
CIBW_MANYLINUX_X86_64_IMAGE: manylinux2014
CIBW_MANYLINUX_AARCH64_IMAGE: manylinux2014

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: wheels
name: wheel-${{ matrix.os }}-${{ matrix.python-build }}
path: ./wheelhouse/*.whl

package_sdist:
Expand All @@ -214,7 +214,7 @@ jobs:
- name: Generate sdist
run: python -m build -s .

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: sdist
path: dist
Loading