Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#189, fix Options type definition and allow custom resolvers. #190

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RopoMen
Copy link

@RopoMen RopoMen commented Nov 1, 2021

No description provided.

@philsturgeon
Copy link
Member

I'll be happy to merge this if you can write a test showing it works as expected, and find somewhere to document how folks can use it. Make sure you rebase on main because there's been a few changes!

@RopoMen
Copy link
Author

RopoMen commented Jun 8, 2022

@philsturgeon
I can rebase this, but I wont be writing any tests because this is just type definition update to make type checks pass.

I can try to find a place where I can place link to this https://apitools.dev/json-schema-ref-parser/docs/plugins/resolvers.html
it tells how to use custom resolvers. Functionality is currently existing, but as I said, type checks wont pass.

I'll try to find some night when I can make rebase, I hope its in next weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants