-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add local tests with Kind #350
base: develop
Are you sure you want to change the base?
Conversation
bd60d77
to
de5280c
Compare
470ef7a
to
6f4fcf3
Compare
6f4fcf3
to
e280ca9
Compare
@sharabiani please take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your branch is behind from develop branch that will have an impact on your changes.
1- Please sync it with develop
branch
2- When synced you'll have new method in core/core setup_k8s_env which I believe will make problems for your testing flow
3- Also get_cluster_credentials
in core is a repeatition to commans/common set_cluster_command
which needs to be addressed.
I have made some changes to address point no. 3 which I will try to merge it to develop in 1-2 days. Meanwhile you can address point no. 1 and we can address no. 2 after our changes both.
ee3df91
to
cf86443
Compare
cf86443
to
ad3a320
Compare
Fixes / Features
Testing / Documentation
Output from the script running tests on Kind: