-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure Pyconfig #1285
base: main
Are you sure you want to change the base?
Restructure Pyconfig #1285
Conversation
d943b05
to
99b807e
Compare
99b807e
to
4d73bdf
Compare
if you'd like to add a unit test, you could for example test that invoking initialize twice creates two different configs, and that attempts to modify a config will result in an error |
4d73bdf
to
6815d67
Compare
Done - thank you Alex! |
6815d67
to
b8a0c99
Compare
b8a0c99
to
1792724
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, thanks Anisha!
Description
Restructure pyconfig.py such that we can create multiple configs. This becomes important if we have a need from an RL workload to have training and inference configs which differ in sharding strategies among others.
We also now use OmegaConfig instead of
yaml.safe_load
and get its benefitsFIXES: b/396747968
Tests
Tested this code with Llama2-7b on v4-8
Checklist
Before submitting this PR, please make sure (put X in square brackets):