Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pathways Recipe Support for Scale Testing #1220

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SujeethJinesh
Copy link
Collaborator

@SujeethJinesh SujeethJinesh commented Jan 31, 2025

Description

This PR contains the following changes:

  1. Adds the following 2 recipes:

    a. Benchmarking Pathways and McJAX code
    b. Long running test on Pathways.

    This is done to improve code/recipe sharing between developers during testing and make benchmarking simpler by
    sharing a single, well-defined config. This will be used for testing and verification on v6e capacity.

  2. By default allows all configs to run pathways (enable_single_controller, disable zarr3, enable_pathways_goodput etc.), with additional configs that can be added by the user with pathways_tuning_params.

  3. Allow removing problematic XLA flags for pathways with pathways_xla_flag_options.

  4. Cleans up a lot of old pathways specific configs.

Tests

Run multiple rounds on multiple v6e clusters

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

@SujeethJinesh SujeethJinesh changed the title Add Pathways Benchmarking Recipes for Scale Testing Add Pathways Benchmarking Recipes for Scale Testing (and fix regression from #1094) Jan 31, 2025
@SujeethJinesh SujeethJinesh force-pushed the sujinesh/add_scale_testing_scripts branch from 38aed8e to 4619286 Compare January 31, 2025 07:32
@SujeethJinesh SujeethJinesh changed the title Add Pathways Benchmarking Recipes for Scale Testing (and fix regression from #1094) Add Pathways Benchmarking Recipes for Scale Testing (and fix bugs) Jan 31, 2025
@SujeethJinesh SujeethJinesh force-pushed the sujinesh/add_scale_testing_scripts branch 4 times, most recently from 59799d7 to 0c9e709 Compare January 31, 2025 22:14
@SujeethJinesh SujeethJinesh force-pushed the sujinesh/add_scale_testing_scripts branch 3 times, most recently from 68bde9d to c344cd0 Compare February 13, 2025 01:34
@SujeethJinesh SujeethJinesh changed the title Add Pathways Benchmarking Recipes for Scale Testing (and fix bugs) Add Pathways Recipe Support for Scale Testing (and fix bugs) Feb 13, 2025
@SujeethJinesh SujeethJinesh force-pushed the sujinesh/add_scale_testing_scripts branch 4 times, most recently from e5f9c2e to 7888e57 Compare February 19, 2025 00:38
@SujeethJinesh SujeethJinesh force-pushed the sujinesh/add_scale_testing_scripts branch 3 times, most recently from ee2a336 to 72df4d8 Compare February 19, 2025 21:39
@SujeethJinesh SujeethJinesh changed the title Add Pathways Recipe Support for Scale Testing (and fix bugs) Add Pathways Recipe Support for Scale Testing Feb 19, 2025
@SujeethJinesh SujeethJinesh force-pushed the sujinesh/add_scale_testing_scripts branch from 72df4d8 to c0b018d Compare February 19, 2025 21:59
@SujeethJinesh SujeethJinesh force-pushed the sujinesh/add_scale_testing_scripts branch from c0b018d to b6c7658 Compare February 19, 2025 22:44
@SujeethJinesh SujeethJinesh marked this pull request as ready for review February 19, 2025 22:44
@SujeethJinesh SujeethJinesh force-pushed the sujinesh/add_scale_testing_scripts branch 3 times, most recently from c7f68ca to 282d737 Compare February 21, 2025 01:54
@SujeethJinesh SujeethJinesh force-pushed the sujinesh/add_scale_testing_scripts branch from 282d737 to e070b70 Compare February 21, 2025 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant