zulip: Don’t carry over last_event_id between queues

It was never possible to use `last_event_id` to request events from before the current queue was created. In Zulip master, this API usage mistake is detected and raised as an error (zulip/zulip#12938), so Snipe would stop receiving messages after a server restart. Signed-off-by: Anders Kaseorg <[email protected]>
1ts-org · Oct 8, 2019 · 355ccc0 · 355ccc0
1 parent 9c14887
commit 355ccc0
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/snipe/zulip.py b/snipe/zulip.py
@@ -131,7 +131,6 @@ async def connect(self):
         self.state_set(messages.BackendState.CONNECTING)
         try:
             self.params = None
-            last_event_id = None
             attempt = 0
             while True:
                 attempt += 1
@@ -158,8 +157,7 @@ async def connect(self):
                     self.params = params
 
                     queue_id = params['queue_id']
-                    if last_event_id is None:
-                        last_event_id = params['last_event_id']
+                    last_event_id = params['last_event_id']
 
                     self._senders |= set(
                         '; '.join((self.name, x['email']))