Skip to content

Commit

Permalink
spelling: github
Browse files Browse the repository at this point in the history
Signed-off-by: Josh Soref <[email protected]>
  • Loading branch information
jsoref committed Nov 20, 2024
1 parent b0a4823 commit 24d5123
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions README.ConfigureResourceReferences.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ Once it's determined, note down the field name and the referenced GCP resource n

Before you can identify what the resource is based on, you must convert
the Google Cloud resource name or Terraform type name into a
Config Connector kind name. Create a Github question in this repo for help
Config Connector kind name. Create a GitHub question in this repo for help
if you still can't find the Config Connector kind name after following these steps:

1. If you know the TF type name, you can do project-scoped search in your local
Expand All @@ -80,7 +80,7 @@ if you still can't find the Config Connector kind name after following these ste
[KCC reference doc](https://cloud.google.com/config-connector/docs/reference/overview).

1. If you can't find a KCC kind with the steps above, it's possible that the
referenced resource is not supported in KCC. Create a Github question in this repo
referenced resource is not supported in KCC. Create a GitHub question in this repo
to clarify. If you've determined that the KCC kind is not supported in
KCC, skip ahead to
[Configure reference resource in the service mappings](#configure-reference-in-the-service-mappings).
Expand Down Expand Up @@ -119,10 +119,10 @@ You can find a `Type` field for each argument, and two most common types are

1. If the field is not required, mark it as an ignored field following
[this example](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/b746248cd5a9b30669380513de8fdc6b4c43018d/config/servicemappings/cloudbuild.yaml#L204).
1. If the field is required, create a Github question in this repo for
1. If the field is required, create a GitHub question in this repo for
further discussion.

1. If the field isn't a string or a list, create a Github question in this repo
1. If the field isn't a string or a list, create a GitHub question in this repo
for further discussion.

## Configure reference resource in the service mappings
Expand Down
2 changes: 1 addition & 1 deletion mockgcp/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Broadly the steps are:

1. Add the proto to the Makefile and run `make gen-proto` (or just `make`).

All google services are located in [googleapis Github repo](https://github.com/googleapis/googleapis/tree/master/google),
All google services are located in [googleapis GitHub repo](https://github.com/googleapis/googleapis/tree/master/google),
refer to your resource's API documentation to identify the service name, for example [privateca](https://cloud.google.com/certificate-authority-service/docs/reference/rest#service:-privateca.googleapis.com).
Once you identify the service, find the proper path to the proto files, for example:
`cloud/security/privateca/v1/*.proto`. Then replace the prefix `googleapis/google/` to `./third_party/googleapis/mockgcp/`,
Expand Down

0 comments on commit 24d5123

Please sign in to comment.