Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log formatting #437

Open
1000TurquoisePogs opened this issue Mar 23, 2022 · 5 comments
Open

Log formatting #437

1000TurquoisePogs opened this issue Mar 23, 2022 · 5 comments
Assignees

Comments

@1000TurquoisePogs
Copy link
Member

Some ZSS logs now have message IDs
Yet, many don't
And none of them have timestamps.
This makes troubleshooting more difficult.
We've tried to implement the format in zowe/zac#90 multiple times and PRs have never finished.
Please lay out rules to follow with logs so that PRs on the subject will succeed.

Previous discussions said things like

  • Don't log library code, use return codes instead
  • Use a log formatting interface so that different users of our codebase can have formats other than the one above, though ZSS will be compiled to use the one above
  • Logging changes added for ZSS should change ZIS. Maybe ZIS needs enhancement at the same time, or maybe certain area of the code shouldn't be touched?

And some thoughts

  • If there are logs where they shouldnt be today, that's a separate problem from adding formatting. We don't need to put PRs on hold if we can move forward one step at a time.
@1000TurquoisePogs
Copy link
Member Author

debug-level tracing really should have logs pervasively, though info-level shouldnt appear in library code since library code should be using RC/RSN instead.

@1000TurquoisePogs
Copy link
Member Author

timestamps must not break ZIS messages (it already has its own)

@1000TurquoisePogs
Copy link
Member Author

Many code comments of old conversations here
zowe/zowe-common-c#126
#160
zowe/zowe-common-c#70

@ifakhrutdinov
Copy link
Contributor

zowe/zowe-common-c#167 has some info too.

ifakhrutdinov added a commit to ifakhrutdinov/zowe-common-c that referenced this issue Apr 20, 2022
@ifakhrutdinov
Copy link
Contributor

ifakhrutdinov commented Apr 20, 2022

I've made a POC based on zowe/zowe-common-c#167:

Wed Apr 20 11:34:06 2022 <ZWES:8FB2F8> TSIRF INFO  ZWES1013I ZSS Server has started. Version '2.0.0+20220420' 31-bit
Wed Apr 20 11:34:06 2022 <ZWES:8FB2F8> TSIRF INFO  fallback to default server settings
Wed Apr 20 11:34:06 2022 <ZWES:8FB2F8> TSIRF INFO  ZWES1038I Server timeouts file '../deploy/instance/serverConfig/timeouts.json' either not found or invalid JSON. ZSS sessions will use the default length of one hour.
Wed Apr 20 11:34:06 2022 <ZWES:8FB2F8> TSIRF INFO  ZWES1101I Product Registration is disabled.
Wed Apr 20 11:34:06 2022 <ZWES:8FB2F8> TSIRF INFO  ZWES1035I ZSS Server settings: Address='127.0.0.1', port='7557', protocol='http'
Wed Apr 20 11:34:06 2022 <ZWES:8FB2F8> TSIRF INFO  ZWES1064I Caching Service not configured
Wed Apr 20 11:34:06 2022 <ZWES:8FB2F8> TSIRF WARN  ZWES1000W Privileged server name not provided, falling back to default.
Wed Apr 20 11:34:06 2022 <ZWES:8FB2F8> TSIRF WARN  ZWES1012W Could not open pluginsDir '../defaults/plugins': Ret='129', res='0x594003d'
Wed Apr 20 11:34:06 2022 <ZWES:8FB2F8> TSIRF INFO  ZWES1039I Installing 'VSAM dataset contents' service...
Wed Apr 20 11:34:06 2022 <ZWES:8FB2F8> TSIRF INFO  ZWES1039I Installing 'dataset metadata' service...
Wed Apr 20 11:34:06 2022 <ZWES:8FB2F8> TSIRF INFO  ZWES1039I Installing 'dataset contents' service...
Wed Apr 20 11:34:06 2022 <ZWES:8FB2F8> TSIRF SEVERE  ZWES1014I ZIS status - 'Failure' (name='ZWESIS_STD      ', cmsRC='12', description='Global area address is NULL', clientVersion='2')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants