-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZSS Logging Improvements #444
base: v2.x/staging
Are you sure you want to change the base?
Conversation
…customer complaints. Signed-off-by: Jordan Filteau <[email protected]>
Signed-off-by: Jordan Filteau <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the idea of improving the logger but please do not invent a different syntax.
This is the format all of the servers except zis/zss are following:
zowe/zac#90
Please revise the PR to make zss match that.
( note, launcher already does as https://github.com/zowe/launcher/blob/v2.x/staging/src/main.c#L288 )
…rmat. Signed-off-by: Jordan Filteau <[email protected]>
@1000TurquoisePogs Gotcha! I've made changes to reflect the documentation you sent me. |
Signed-off-by: Jordan Filteau <[email protected]>
Signed-off-by: Jordan Filteau <[email protected]>
Signed-off-by: Jordan Filteau <[email protected]>
Signed-off-by: Jordan Filteau <[email protected]>
Signed-off-by: Jordan Filteau <[email protected]>
… updating nolongname Signed-off-by: Jordan Filteau <[email protected]>
…mmon-c into jordan-logging-improvements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comments.
And another note: I don't think you have addressed my concerns (in the issue) about the handler2
being potentially missing in a mixed level environment. Do you think we need to worry about that?
@ifakhrutdinov thanks so much for reviewing! I'll get to these :). |
Signed-off-by: Jordan Filteau <[email protected]>
Signed-off-by: Jordan Filteau <[email protected]>
Signed-off-by: Jordan Filteau <[email protected]>
Signed-off-by: Jordan Filteau <[email protected]>
Proposed changes
Changing the logging format to have useful information. I've added the following:
It looks like this:
2024-04-30 18:53:40.345 ZWESZ1:0x8FB2F8:0x37455E58:67241934 TS5873 CRITICAL (loggingtest.c:main:18) oh no!
Type of change
Please delete options that are not relevant.
Testing
It should be non-breaking. If the new code is in, then the log messages done by ZSS will have the additional metadata by default.
Output from
loggingtest.c
.This demonstrates support for backwards compatibility and native improvements to all current log statements, without changing code.
Further comments
Note: I think that we should move toward a logger that takes a message key and has messages stored in JSON or YAML with various metadata. This is something that I believe would be useful.
{ "key": "someZssError", "prefix": "ZSS", "number": 1, "severity": "I", "format": "This is a test message: %s." }