Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Issue with socketio #10

Open
tianlang0704 opened this issue May 13, 2024 · 0 comments
Open

Performance Issue with socketio #10

tianlang0704 opened this issue May 13, 2024 · 0 comments

Comments

@tianlang0704
Copy link
Contributor

tianlang0704 commented May 13, 2024

Following #6
After I disabled all other custom nodes in ComfyUI the extremely long delay in request.post() was gone. And the performance became acceptable with 1.x seconds for simple get & send.
Weirdly enough, the delay was originated in a stdlib...
email/utils.py:280 => new_params.append((name, '"%s"' % quote(value)))
The operation was formatting a string + putting string into tuple + appending the tuple into a list...
There's no multi-threading, it is all on main thread. It's gone when I disabled other custom nodes. I don't know which one is conflicting with it, and I am too lazy to go find it. So until someone else encounters the same problem, I think I am going leave it alone.
await request.post() SIO with Long Delay: 15s
image

Putting that long delay aside. The post still took about 1 seconds without the long delay.

await request.post() SIO without Long Delay: 1s
image

await request.post() aiohttp Websocket: 7ms
image

The difference is large but I think this performance is no major impact to the user experience for now.
If this is acceptable, I think we can close this until further actions need to be done.

@zombieyang zombieyang mentioned this issue Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant