Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: modular two point and three point value #474

Open
jdabapo opened this issue Feb 18, 2025 · 0 comments
Open

Feat: modular two point and three point value #474

jdabapo opened this issue Feb 18, 2025 · 0 comments

Comments

@jdabapo
Copy link

jdabapo commented Feb 18, 2025

I wrote a few changes to make the values of three pointers and two pointers changeable. I tried to map out to the extent where these values were hard coded in the index.ts sim function, and adjusted the values there. One place I wasn't sure where changes should be made was the forceThreePointer boolean, which is set when the value for time is low enough and the losing team needs to make three pointers. Other than that, I think it should be a pretty simple change?

This is in reference to the TODO:

zengm/TODO

Line 1105 in d4ad5f2

change point value of 2/3 pointers https://old.reddit.com/r/BasketballGM/comments/ko1zy7/monthly_suggestions_thread/gjtthn2/

This is the github Fork for this change, I wasn't sure the flow for submitting changes would be.

https://github.com/jdabapo/zengm-adjustPointValues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant