Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I suggest to don't use relative import in SpriteMapper project #21

Open
harobed opened this issue Dec 16, 2011 · 0 comments
Open

I suggest to don't use relative import in SpriteMapper project #21

harobed opened this issue Dec 16, 2011 · 0 comments

Comments

@harobed
Copy link
Contributor

harobed commented Dec 16, 2011

Hi,

I suggest to don't use this syntax :

from . import SpriteRef
from .config import CSSConfig
from .css import split_declaration

but use this syntax :

from spritemapper import SpriteRef
from spritemapper.config import CSSConfig
from spritemapper.css import split_declaration

Generally, I don't see and I don't use relative import.
Usual python project convention don't use relative import.

Lately, I've executed this command :

$ python ../Spritemapper/spritecss/finder.py mime.css
Traceback (most recent call last):
  File "../Spritemapper/spritecss/finder.py", line 7, in <module>
    from . import SpriteRef
ValueError: Attempted relative import in non-package

If the project don't use relative import, I would not get this error.

What do you think about this suggestion ?

I can fix it if you want ?

Regards,
Stéphane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant