Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revisiting snapshots at simulation stages #187

Open
feefladder opened this issue Mar 28, 2021 · 0 comments
Open

revisiting snapshots at simulation stages #187

feefladder opened this issue Mar 28, 2021 · 0 comments

Comments

@feefladder
Copy link
Contributor

problem

As mentioned in #164 and #179, the saving of snapshots can be revisited now we have the ability to update a variable inside a process step (#178 and #179). This would make using finalize_step in a model obsolete. However, this is quite a breaking change, and therefore should have a deprecation cycle.

Also, I don't know what can be done before finalize_step is removed.

proposal

  1. issue a warning when the user uses finalize_step in a model, pointing to the documentation Docs #182. and mentioning when the feature is to be deprecated.
  2. actually deprecate the feature, and reduce the entire snapshots system
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant