-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
visualising inout
dependencies
#181
Comments
feefladder
pushed a commit
to feefladder/xarray-simlab
that referenced
this issue
Mar 27, 2021
#184 will not address 2. I think that it will help users in debugging custom dependencies however, what are your thoughts on that? |
4 tasks
added an example notebook for why 2. is useful. For example when a user does not understand the error messages of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I feel a bit guilty that #164 was initially about visualizing inout variables, but that has not been properly addressed in the following discussion or PRs. Furthermore, the checking algorithm works, but may be a bit aggressive. The user still does not really have a good way to see all relationships, such as seeming cycles as @jvail initially intendet. Therefore, the following proposal for two different options in the visualisation:
inout
process to all firstin
processes for all variables. as an option in visualisemodel.visualize(cycle_arrows=True)
e.g.:show_only_variable
or separatemodel.visualize(show_variable_stages='p_name__var_name')
This would make it clear for the user if processes are updated or not before they are used.
Both require a similar algorithm to work, but 2 is quite more complex to implement.
The text was updated successfully, but these errors were encountered: